From 94d5afd7c07310addcd75a030168ed633ca710e3 Mon Sep 17 00:00:00 2001 From: trialuser02 Date: Tue, 23 Jul 2019 20:24:06 +0000 Subject: fixed possible memory leak and other issues git-svn-id: http://svn.code.sf.net/p/qmmp-dev/code/trunk/qmmp@9011 90c681e8-e032-0410-971d-27865f9a5e38 --- src/plugins/General/fileops/hotkeydialog.cpp | 3 +-- src/plugins/Transports/http/httpstreamreader.cpp | 2 +- src/plugins/Ui/qsui/shortcutdialog.cpp | 3 +-- src/qmmp/metadatamanager.cpp | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/plugins/General/fileops/hotkeydialog.cpp b/src/plugins/General/fileops/hotkeydialog.cpp index 758a76a07..65f116c44 100644 --- a/src/plugins/General/fileops/hotkeydialog.cpp +++ b/src/plugins/General/fileops/hotkeydialog.cpp @@ -1,5 +1,5 @@ /*************************************************************************** - * Copyright (C) 2009 by Ilya Kotov * + * Copyright (C) 2009-2019 by Ilya Kotov * * forkotov02@ya.ru * * * * This program is free software; you can redistribute it and/or modify * @@ -47,7 +47,6 @@ void HotkeyDialog::keyPressEvent (QKeyEvent *event) case Qt::Key_Menu: case 0: case Qt::Key_unknown: - key = 0; ui.keyLineEdit->clear(); QWidget::keyPressEvent(event); return; diff --git a/src/plugins/Transports/http/httpstreamreader.cpp b/src/plugins/Transports/http/httpstreamreader.cpp index 0cefbe775..bdf241ac0 100644 --- a/src/plugins/Transports/http/httpstreamreader.cpp +++ b/src/plugins/Transports/http/httpstreamreader.cpp @@ -451,7 +451,7 @@ void HttpStreamReader::checkBuffer() void HttpStreamReader::readICYMetaData() { - uint8_t packet_size; + uint8_t packet_size = 0; m_metacount = 0; m_mutex.lock(); diff --git a/src/plugins/Ui/qsui/shortcutdialog.cpp b/src/plugins/Ui/qsui/shortcutdialog.cpp index 311e53c14..51b357e0f 100644 --- a/src/plugins/Ui/qsui/shortcutdialog.cpp +++ b/src/plugins/Ui/qsui/shortcutdialog.cpp @@ -1,5 +1,5 @@ /*************************************************************************** - * Copyright (C) 2010-2013 by Ilya Kotov * + * Copyright (C) 2010-2019 by Ilya Kotov * * forkotov02@ya.ru * * * * This program is free software; you can redistribute it and/or modify * @@ -51,7 +51,6 @@ void ShortcutDialog::keyPressEvent (QKeyEvent *event) case Qt::Key_Menu: case 0: case Qt::Key_unknown: - key = 0; m_ui.keyLineEdit->clear(); QWidget::keyPressEvent(event); return; diff --git a/src/qmmp/metadatamanager.cpp b/src/qmmp/metadatamanager.cpp index 11ca5c7aa..ffacd817f 100644 --- a/src/qmmp/metadatamanager.cpp +++ b/src/qmmp/metadatamanager.cpp @@ -310,7 +310,7 @@ void MetaDataManager::prepareForAnotherThread() MetaDataManager *MetaDataManager::instance() { if(!m_instance) - new MetaDataManager(); + m_instance = new MetaDataManager(); return m_instance; } -- cgit v1.2.3-13-gbd6f