From 591632121a1e74e61a83c3a15e0909ef9e685ef8 Mon Sep 17 00:00:00 2001 From: trialuser02 Date: Thu, 7 Jan 2021 13:21:12 +0000 Subject: some code optimization git-svn-id: http://svn.code.sf.net/p/qmmp-dev/code/trunk/qmmp@9617 90c681e8-e032-0410-971d-27865f9a5e38 --- src/plugins/General/library/library.cpp | 3 +-- src/plugins/General/streambrowser/streambrowser.cpp | 3 +-- src/plugins/Ui/skinned/playlist.cpp | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/plugins/General/library/library.cpp b/src/plugins/General/library/library.cpp index 7d9c92365..7f4db5f82 100644 --- a/src/plugins/General/library/library.cpp +++ b/src/plugins/General/library/library.cpp @@ -60,8 +60,7 @@ Library::Library(QObject *parent) : QObject(parent) QSettings settings(Qmmp::configFile(), QSettings::IniFormat); m_dirs = settings.value("Library/dirs").toStringList(); - QAction *action = new QAction(tr("Update library"), this); - action->setIcon(QIcon::fromTheme("view-refresh")); + QAction *action = new QAction(QIcon::fromTheme("view-refresh"), tr("Update library"), this); UiHelper::instance()->addAction(action, UiHelper::TOOLS_MENU); connect(action, SIGNAL(triggered()), SLOT(startDirectoryScanning())); } diff --git a/src/plugins/General/streambrowser/streambrowser.cpp b/src/plugins/General/streambrowser/streambrowser.cpp index b8ad3d5a2..b9fec50c5 100644 --- a/src/plugins/General/streambrowser/streambrowser.cpp +++ b/src/plugins/General/streambrowser/streambrowser.cpp @@ -30,8 +30,7 @@ StreamBrowser::StreamBrowser(QObject *parent) : QObject(parent) { - m_action = new QAction(tr("Add Stream"), this); - m_action->setIcon(QIcon::fromTheme("applications-internet")); + m_action = new QAction(QIcon::fromTheme("applications-internet"), tr("Add Stream"), this); m_action->setShortcut(tr("Ctrl+U")); UiHelper::instance()->addAction(m_action, UiHelper::ADD_MENU); connect (m_action, SIGNAL(triggered ()), SLOT(showStreamWindow())); diff --git a/src/plugins/Ui/skinned/playlist.cpp b/src/plugins/Ui/skinned/playlist.cpp index 86fc76f98..92ca9e667 100644 --- a/src/plugins/Ui/skinned/playlist.cpp +++ b/src/plugins/Ui/skinned/playlist.cpp @@ -609,13 +609,13 @@ void PlayList::showPlayLists() void PlayList::generateCopySelectedMenu() { m_copySelectedMenu->clear(); - QAction* action = m_copySelectedMenu->addAction (tr ("&New PlayList")); + QAction* action = m_copySelectedMenu->addAction (tr("&New PlayList")); action->setIcon(QIcon::fromTheme("document-new")); m_copySelectedMenu->addSeparator(); for(QString name : m_pl_manager->playListNames()) { - m_copySelectedMenu->addAction("&"+name.replace("&", "&&")); + m_copySelectedMenu->addAction("&" + name.replace("&", "&&")); } } -- cgit v1.2.3-13-gbd6f